Allow to specify I2C address of LED Matrix #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebromero
force-pushed
the
led_matrix_multi
branch
from
3b3b9a6 to
1b1372e
Compare
There was a problem hiding this comment.
Pull request overview
This pull request adds the ability to specify a custom I2C address for the LED Matrix module, addressing scenarios where multiple devices might share the I2C bus or where the default address conflicts with other hardware.
Key changes:
- Introduces a
DEFAULT_ADDRESSconstant (0x39) to replace the hardcoded address - Adds an
_addressmember variable to store the configurable I2C address - Provides two constructor overloads allowing users to specify the address in different parameter orders while maintaining backward compatibility
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
facchinm
approved these changes
Dec 11, 2025
Contributor
|
👋 can you rebase on top of |
sebromero
force-pushed
the
led_matrix_multi
branch
from
cc26c03 to
f4e7186
Compare
Contributor
Author
|
@facchinm Done. Didn't realize that we have the LED matrix on main. Maybe we can remove the |
Contributor
|
Yup, removing it right now 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to specify the LED matrix I2C address via constructor. That way multiple LED matrices can be daisy chained. Remember to change the address of the additional matrices for this to work.